Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Fix #172: Enable WhiteNoise #116

Merged

Conversation

openjck
Copy link
Contributor

@openjck openjck commented Mar 15, 2016

No description provided.

@openjck
Copy link
Contributor Author

openjck commented Mar 15, 2016

The one thing this is missing is a production mode like we have on MDN. We can set DJANGO_DEBUG=False but nothing serves up the files in /static. I'll have to keep thinking about it.

@groovecoder
Copy link
Collaborator

We still have the problem where the pipeline-generated css/dashboard.css and js/dashboard.js aren't served by whitenoise.

I.e., with DJANGO_DEBUG=False, whitenoise collects the individual static files and serve them (e.g., applications.3f46d1c0875e.css, details.e54257cd969c.css, etc.) but it doesn't create the necessary dashboard.6d344fe82057.css combined file to serve.

@openjck openjck force-pushed the issue-172-enable-whitenoise branch 2 times, most recently from f02413b to 16e35a4 Compare March 17, 2016 21:03
@openjck openjck force-pushed the issue-172-enable-whitenoise branch from 16e35a4 to 2f3bf09 Compare March 17, 2016 21:04
@openjck
Copy link
Contributor Author

openjck commented Mar 17, 2016

Ah, good catch. Fixed. Testing in production mode is a lot easier than I thought, too.

@groovecoder
Copy link
Collaborator

Ah, looks good now.

groovecoder added a commit that referenced this pull request Mar 18, 2016
@groovecoder groovecoder merged commit 9390812 into mozilla-services:master Mar 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants