This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Refactor libmemcached adapter pooling; adjust timeouts #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restrict `MaxConns` to 100.
* Allow specifying `""` or `"0"` as durations to disable timeouts.
* Adjust `{Recv, Send, Retry}Timeout` to match the docs.
* Disable `PollTimeout` by default. The 10ms timeout was causing
intermittent smoke test failures.
* Replace the run loop with a `sync.Cond`.
|
r+ |
bbangert
added a commit
that referenced
this pull request
Mar 3, 2015
Refactor libmemcached adapter pooling; adjust timeouts
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority for v1.6...
MaxConnsto 100, and adjust{Recv, Send, Retry}Timeoutto match the docs and sample config.""or"0"as durations to disable timeouts.PollTimeoutby default. The 10ms timeout was causing intermittent smoke test failures. This should also take care of some of the timeout issues we were seeing.sync.Cond—partly because it avoids funneling all pool requests and releases through a channel, and partly because I wanted to understand condition variables.