New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use material-ui for the generated forms #39
Comments
See https://www.google.com/design/spec/components/text-fields.html#text-fields-character-counter for an example of field. |
I really think this lib shouldn't enforce using any css framework at all. But I understand it might please users to have something beautiful by default. Dilemma. |
Then the question could become "how do we let users specify the components they want", which might be something possible via what's described in https://github.com/mozilla-services/react-jsonschema-form#custom-widgets (I just actually discovered this). Do you think this will be enough? |
I don't know, you might want to play a bit with it to find out :) What's sure, I don't feel at all like embedding a CSS framework in this project; I'd rather provide the DOM extension required mechanisms so users can bring their own element tags and attributes, so custom schema fields and widgets are probably the way to go, and we'll add anything missing if we can. One thing is CSS frameworks usually heavily rely on a very specific HTML nested structures, tag & class names, semantics, etc., while React doesn't really offer easy to use mechanisms to alter/extend/override these at a given specific node level. Kinda conflicting purposes. Time for a React-XSLT lib? LOLNOPE. |
For material design, there is http://react-toolbox.com too. |
@almet, for a more opinionated package try react-schema-form. I think it's exactly what you're looking for: it uses the material-ui package and the same json-schema standard (via tv4) |
Following my comment above, I'm closing this. Feel free to reopen and discuss if you feel this is wrong. |
Material-UI made beta 1, React-Toolbox is still on React 15. |
Should we use this? The look and fill could improve a lot, but at the same time I wonder if that's really what this library should do.
https://github.com/callemall/material-ui
Thoughts?
The text was updated successfully, but these errors were encountered: