Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "0." to be typed in to a text widget #1360

Merged
merged 3 commits into from
Aug 10, 2019
Merged

Allow "0." to be typed in to a text widget #1360

merged 3 commits into from
Aug 10, 2019

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented Jul 16, 2019 •
edited
Loading

Reasons for making this change

Fixes #1355.

Changed some of the number field tests to run both on the default uiSchema and the uiSchema with the input type set to "text".

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace epicfaace mentioned this pull request Jul 16, 2019
Closed
3 tasks
@epicfaace
Copy link
Member Author

@edi9999 / @LucianBuzzo can you review when you get a chance?

@epicfaace epicfaace merged commit 20ff3b9 into master Aug 10, 2019
@epicfaace epicfaace deleted the fix-numbers-zero branch August 10, 2019 15:22
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edi9999 edi9999 edi9999 approved these changes

@LucianBuzzo LucianBuzzo Awaiting requested review from LucianBuzzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'0.*' not valid number value when trying to add value
3 participants
@epicfaace @edi9999 @abouchard97