Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The website link and the created time are no longer displayed on the saved shot preview page, if the expire date is changed #3255

Closed
SoftVision-CosminMuntean opened this issue Aug 1, 2017 · 4 comments
Assignees
Labels
defect P2 [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 56.0a1
  • Beta 55.0b13
  • Screenshots 10.9.0

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Start the Nightly or Beta browser using a new clean profile.
  2. Navigate to any website and save a selection on the page.
  3. Click the "expires in 14 days" button.
  4. Change the expire date and click the "Save" button.
  5. Observer the shot details.

[Expected result]:

  • All the details are correctly redisplayed after the expired date was changed.

[Actual results]:

  • The website link and the created time is no longer displayed.

[Notes]:

  • If the page is refreshed the details reapers.
  • Here is a screen recording with the issue:
    details
@ghost ghost added this to the General Release 57 milestone Aug 1, 2017
@ghost ghost assigned jaredhirsch Aug 1, 2017
@johngruen johngruen added the P2 label Aug 17, 2017
@jaredhirsch
Copy link
Member

React doesn't seem to like how TimeDiffs contain different times, depending on whether they are rendered on the server (UTC) or client (local time).

@jaredhirsch
Copy link
Member

Here's a screenshot of a console error indicating React's displeasure:

screen shot 2017-08-31 at 5 27 07 pm

@johngruen
Copy link
Contributor

I put this back in triage because of a report by community member @peterbe

@SoftVision-CosminMuntean
Copy link
Author

This issue is no longer reproducible on latest Screenshots 31.3.0 dev version. Tested on latest Nightly (61.0a1) build on Windows 7 x64, Mac 10.13 and Arch Linux.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect P2 [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

5 participants