Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The background of the buttons from the Screenshots overlay is wrongly transparent #3565

Closed
SoftVision-CosminMuntean opened this issue Sep 29, 2017 · 5 comments
Milestone

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 58.0a1
  • Screenshots 21.0.0

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

[Steps to reproduce]:

  1. Start the browser with the profile from prerequisites and navigate to any website.
  2. Click the Screenshots button from Nightly "Page Action" and dismiss the tour.
  3. Observe the buttons from the top right of the page.

[Expected result]:

  • The buttons are correctly displayed and have a grey background (100% opacity).

[Actual results]:

  • The background of the buttons is transparent.

[Notes]:

  • This issue is no reproducible on stage and production servers.
  • Here is a screenshot with the issue:
    screenshots buttons
@ghost
Copy link

ghost commented Sep 29, 2017

This is a side effect of high-contrast mode.

@ghost ghost added this to the Launch 58 milestone Sep 29, 2017
@ianb
Copy link
Contributor

ianb commented Sep 29, 2017

From this question it looks like there's a media query that applies to high contrast mode.

@SoftVision-CosminMuntean
Copy link
Author

This issue is also reproducible with Screenshots (22.0.0) on stage server. Since this issue is a regression of the background of the buttons, we should fix this before landing the High-Contrast patch in Beta 57.

@SoftVision-CosminMuntean SoftVision-CosminMuntean changed the title [Dev] The background of the buttons from the Screenshots overlay is wrongly transparent The background of the buttons from the Screenshots overlay is wrongly transparent Oct 2, 2017
jaredhirsch added a commit that referenced this issue Oct 2, 2017
@ianb ianb closed this as completed in 8bcf729 Oct 3, 2017
@jaredhirsch
Copy link
Member

Fixed by #3583

@SoftVision-CosminMuntean
Copy link
Author

I have retested this issue on latest Nightly 58.0a1 build using Screenshots dev (22.0.0) version and the issue is no longer reproducible. Marking as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants