Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Inconsistent deletion messaging #4186

Closed
sevaan opened this issue Mar 5, 2018 · 3 comments
Closed

Inconsistent deletion messaging #4186

sevaan opened this issue Mar 5, 2018 · 3 comments
Assignees
@chenba
Labels
ux polish
Milestone
Sprint 11 (61-3) 👗

Comments

@sevaan
Copy link
Collaborator

sevaan commented Mar 5, 2018

When deleting an image from the library view, I see this message:

screen shot 2018-03-05 at 1 30 08 pm

When deleting from the image view, the message is:

screen shot 2018-03-05 at 1 30 24 pm

Let's pick one and use it for both areas. I feel like the latter offers more clarity, so let's use that.
@johngruen
Copy link
Contributor

Let's go with the second one.

@ghost ghost added the skill:js label Mar 20, 2018
@johngruen
Copy link
Contributor

Hey @sevaan could we make a custom message UI for both cases?

@johngruen johngruen added this to the Sprint 9 (61-1) 👋 milestone Mar 20, 2018
@sevaan
Copy link
Collaborator Author

sevaan commented Mar 21, 2018 •
edited
Loading

Custom Deletion UI:

image

image

Measurements found here Also in this link, measurements for updated Share panel (#4249).

@sevaan sevaan mentioned this issue Mar 21, 2018
Closed
@sevaan sevaan removed the needs:UX label Mar 21, 2018
@ghost ghost modified the milestones: Sprint 9 (61-1) 👋, Sprint 10 (61-2) ⛅ Apr 2, 2018
@chenba chenba self-assigned this Apr 12, 2018
chenba added a commit to chenba/screenshots that referenced this issue Apr 14, 2018
@chenba
Update shot delete confirmation dialog. (mozilla-services#4186)
e32edac
chenba added a commit to chenba/screenshots that referenced this issue Apr 14, 2018
@chenba
Update shot delete confirmation dialog. (mozilla-services#4186)
78c325e
@chenba chenba mentioned this issue Apr 14, 2018
Merged
chenba added a commit to chenba/screenshots that referenced this issue Apr 16, 2018
@chenba
Update shot delete confirmation dialog. (mozilla-services#4186)
70d9d6a
@ghost ghost modified the milestones: Sprint 10 (61-2) ⛅, Sprint 11 (61-3) 👗 Apr 16, 2018
chenba added a commit to chenba/screenshots that referenced this issue Apr 25, 2018
@chenba
Update shot delete confirmation dialog. (mozilla-services#4186)
eb6d850
jaredhirsch pushed a commit that referenced this issue Apr 25, 2018
@chenba @jaredhirsch
Update shot delete confirmation dialog. (#4186) (#4341)
10bc456
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
@chenba
Update shot delete confirmation dialog. (mozilla-services#4186) (mozi…
324fb38 
…lla-services#4341)
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
Revert "Update shot delete confirmation dialog. (mozilla-services#4186)…
49d48b3 
… (mozilla-services#4341)"

This reverts commit 324fb38.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
ux polish
Projects
None yet
Milestone
Sprint 11 (61-3) 👗
Development

No branches or pull requests
3 participants
@chenba @sevaan @johngruen