Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The string in the title attribute in the edit button is not localised #4206

Closed
cecilebertin opened this issue Mar 9, 2018 · 2 comments
Closed

The string in the title attribute in the edit button is not localised #4206

cecilebertin opened this issue Mar 9, 2018 · 2 comments
Assignees
@chenba
Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team.
Milestone
Sprint 9 (61-1) 👋

Comments

@cecilebertin
Copy link
Collaborator

The string for the title attribute from the edit button is not translated.
capture d ecran 2018-03-08 a 17 29 28
@SoftVision-CosminMuntean
Copy link

It seems that also the tooltip for the "Color Picker" button and for the color buttons is not localized.

Here is a screens recording with the issue:
color picker tooltip

@johngruen johngruen added this to the Sprint 9 (61-1) 👋 milestone Mar 12, 2018
@flodolo
Copy link
Collaborator

flodolo commented Mar 12, 2018

Hardcoded Edit this image was introduced in #4141. Color Picker in #3880

chenba added a commit to chenba/screenshots that referenced this issue Mar 23, 2018
@chenba
Add l10n title messages for edit btn and colors. (mozilla-services#4206)
df1e394
@chenba chenba self-assigned this Mar 23, 2018
@chenba chenba mentioned this issue Mar 23, 2018
Merged
jaredhirsch pushed a commit that referenced this issue Mar 26, 2018
@chenba @jaredhirsch
Add l10n title messages for edit btn and colors. (#4206) (#4265)
81ab9ce
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Other issue Valid issues logged by other people than the Softvision QA team. label Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team.
Projects
None yet
Milestone
Sprint 9 (61-1) 👋
Development

No branches or pull requests
5 participants
@chenba @johngruen @flodolo @SoftVision-CosminMuntean @cecilebertin