bug 1258038: add DNT lists to stage.ini config #11
Conversation
|
I think this is how we'll deploy the new list config to stage. |
|
are these "stage-only" forever, or "stage for now, one day, prod" |
|
Stage for now, one day: prod. |
| disconnect_url=https://raw.githubusercontent.com/mozilla-services/shavar-prod-lists/master/disconnect-blacklist.json | ||
| output=basew3c-track-digest256 | ||
|
|
||
| # DNT="", content category |
There was a problem hiding this comment.
As I mentioned on https://github.com/mozilla-services/shavar-list-creation/pull/37/files#r66558758, we could add "content category only" to these to make it clearer.
|
r+ with or without the comment tweak I suggested. |
groovecoder
force-pushed
the
add-dnt-lists-1258038
branch
from
f45e14c
to
c47b2ce
Compare
|
@fmarier - I added |
|
The S3 names look good to me. r+. |
|
I'd like to wait on merging this to the master branch until QA has had a chance to do end to end testing of the new lists in stage with the up-coming deploy. We're currently using this branch to generate the lists in stage and there's been no issues, but if this is merged, those lists and code changes will appear in prod without the benefit of a full QA cycle. If I'm mistaken on that, please feel free to explain. Pending that QA cycle, however, r+. |
|
Thanks :ckolos |
|
Updated branch with f6b8c37 to remove mozpub-track from stage.ini |
No description provided.