Skip to content

Commit

Permalink
bug 1784485: remove assertion that will always pass
Browse files Browse the repository at this point in the history
This removes an assertion that's always true because the thing it's
testing didn't happen can never happen.

This also fixes another test giving it a better "empty json_dump".
  • Loading branch information
willkg committed Aug 16, 2022
1 parent b9005bb commit ae83bef
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions webapp-django/crashstats/crashstats/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,6 @@ def mocked_processed_crash_get(**params):
"You need to be logged in and have access to protected data to see "
"links to crash report data."
) in content
# Should not be able to see sensitive key from stackwalker JSON
assert ""sensitive"" not in content

# The pretty platform version should appear.
assert "OS X 10.11" in content
Expand Down Expand Up @@ -1495,7 +1493,7 @@ def mocked_processed_crash_get(**params):
assert "<th>Install Time</th>" not in smart_str(response.content)

def test_report_index_with_sparse_json_dump(self):
json_dump = {"status": "ERROR_NO_MINIDUMP_HEADER", "sensitive": {}}
json_dump = {"stackwalker_version": "minidump_stackwalk 0.10.3 ..."}

def mocked_raw_crash_get(**params):
assert "datatype" in params
Expand Down

0 comments on commit ae83bef

Please sign in to comment.