Skip to content

Commit

Permalink
bug 1394867: make CoUnmarshalInterfaceResult public
Browse files Browse the repository at this point in the history
This makes CoUnmarshalInterfaceResult public and it also adds it to the
processed crash.

The value is in hexidecimal. I'm copying it over as a string figuring
it's more useful that way as opposed to converting it to decimal. We can
change it if the theory turns out to be false.
  • Loading branch information
willkg committed May 10, 2022
1 parent 96cf6c1 commit d062dbd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions socorro/processor/rules/mozilla.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ class CopyFromRawCrashRule(Rule):
("int", "AvailableVirtualMemory", "available_virtual_memory"),
("string", "BIOS_Manufacturer", "bios_manufacturer"),
("string", "CoMarshalInterfaceFailure", "co_marshal_interface_failure"),
# NOTE(willkg): This is an integer, but it's in hex. I'm treating it as a string
# rather than converting it to a decimal integer because I think it's going to
# be more helpful.
("string", "CoUnmarshalInterfaceResult", "co_unmarshal_interface_result"),
("boolean", "ContainsMemoryReport", "contains_memory_report"),
("int", "ContentSandboxCapabilities", "content_sandbox_capabilities"),
("boolean", "ContentSandboxCapable", "content_sandbox_capable"),
Expand Down
2 changes: 2 additions & 0 deletions webapp-django/crashstats/crashstats/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,7 @@ class ProcessedCrash(SocorroMiddleware):
"build",
"client_crash_date",
"completed_datetime",
"co_unmarshal_interface_result",
"cpu_arch",
"cpu_info",
"crashedThread",
Expand Down Expand Up @@ -802,6 +803,7 @@ class RawCrash(SocorroMiddleware):
"buildid",
"BuildID",
"CrashTime",
"CoUnmarshalInterfaceResult",
"DOMIPCEnabled",
"EMCheckCompatibility",
"FlashVersion",
Expand Down

0 comments on commit d062dbd

Please sign in to comment.