Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1671276: process breadcrumbs and show on details page #5650

Merged
merged 1 commit into from Jan 9, 2021
Merged

bug 1671276: process breadcrumbs and show on details page #5650

merged 1 commit into from Jan 9, 2021

Commits on Jan 9, 2021

  1. bug 1671276: process breadcrumbs and show on details page

    The crash reporter in android-components which Fenix uses captures
    breadcrumbs and puts it in the Breadcrumbs annotation.
    
    This adds a processor rule to validate it and add it to the processed
    crash and then display it in the Details of the report view.
    
    Note that we tried to use the same structure that Sentry uses, however
    Sentry's breadcrumbs structure looks like this:
    
    {
      "breadcrumbs": {
        "values": [
          crumb,
          crumb,
          crumb,
        ]
      }
    }
    
    and ours look like this:
    
    {
      "breadcrumbs": [
        crumb,
        crumb,
        crumb,
      ]
    }
    
    This code normalizes the Sentry form to ours because the validation is
    easier that way. In the future, we should make sure that's what we want
    to do and adjust accordingly.
    
    This marks it as protected data, so if you don't have access to that,
    you can't see it.
    
    This doesn't make it searchable. I decided not to deal with that until I
    know more about how people want to search it (or even if people do want
    to search it).
    willkg committed Jan 9, 2021
    Copy the full SHA
    f127fd1 View commit details
    Browse the repository at this point in the history