Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All mozilla.org websites are whitelisted #79

Merged
merged 3 commits into from Jun 7, 2018
Merged

All mozilla.org websites are whitelisted #79

merged 3 commits into from Jun 7, 2018

Conversation

hoosteeno
Copy link
Contributor

@hoosteeno hoosteeno commented May 29, 2018 •
edited

This fixes #78 . Notes:

  • The docs I've seen don't adequately explain how to prepare an environment suitable for testing, so I didn't do that. Before merging, this code should be tested to ensure the new whitelist works as expected.

@hoosteeno hoosteeno mentioned this pull request May 29, 2018
Closed
@chrismore
Copy link

@oremj can you help here?

@oremj oremj self-requested a review June 7, 2018 20:59
oremj
oremj suggested changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@oremj oremj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit tests.

@oremj oremj merged commit d5d6129 into mozilla-services:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oremj oremj oremj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mozilla.org to regex section of whitelist
3 participants
@hoosteeno @chrismore @oremj