Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mozilla.org to regex section of whitelist #78

Closed
hoosteeno opened this issue Apr 11, 2018 · 3 comments · Fixed by #79
Closed

Add mozilla.org to regex section of whitelist #78

hoosteeno opened this issue Apr 11, 2018 · 3 comments · Fixed by #79

Comments

@hoosteeno
Copy link
Contributor

hoosteeno commented Apr 11, 2018

We currently include several critical global domains in the regex section of the whitelist:

https://github.com/mozilla-services/stubattribution/blob/master/attributioncode/sourcewhitelist.go#L18

We even include everything at our testing domain, *.allizom.org, and everything at *.firefox.com. But we don't include our production domain, mozilla.org. That means any mozilla subdomain that wishes to drive attributed product downloads must request a one-off rule to be added to the whitelist. Example: blog.mozilla.org, which spent a great deal of 2017 driving downloads, is not on the list and so we have no attribution data for it.

Can we add ^[\w-]*\.mozilla\.org$ to the regex whitelist? We can remove one-off subdomains from the individual list of rules at the same time.

@chrismore
Copy link

@oremj ^^

@hoosteeno
Copy link
Contributor Author

I hate to be a squeaky wheel, but not having attribution data for most mozilla.org sites makes it very difficult to talk about the impact of user download journeys on firefox user retention. And we have to do that in 2018. @oremj if I submit a PR for this would you be able to review it?

@hoosteeno
Copy link
Contributor Author

hoosteeno commented May 29, 2018

PR #79 fixes this. @oremj r?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants