Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a canonical session timestamp #55

Closed
pjenvey opened this issue Oct 9, 2018 · 0 comments
Closed

Create a canonical session timestamp #55

pjenvey opened this issue Oct 9, 2018 · 0 comments
Assignees
@pjenvey

Comments

@pjenvey
Copy link
Member

pjenvey commented Oct 9, 2018

The initial mysql support more matches go-syncstorage's handling of what's essentially a per session 'modified' timestamp.

We should more closely match the python version by creating the timestamp in one place per API call (per SqlStorageSession). Likely living in a similar DbSession struct within the Db impl.
@pjenvey pjenvey self-assigned this Oct 9, 2018
@bbangert bbangert mentioned this issue Oct 9, 2018
Closed
12 tasks
@pjenvey pjenvey mentioned this issue Oct 9, 2018
Closed
pjenvey added a commit that referenced this issue Oct 10, 2018
@pjenvey
refactor: create a db Session w/ a canonical timestamp
9158eff 
and quiet a warning under #[cfg(test)]

Closes #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjenvey