Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch db interface back to collection: String (vs collection_id: i32) #57

Closed
pjenvey opened this issue Oct 9, 2018 · 0 comments
Closed

Switch db interface back to collection: String (vs collection_id: i32) #57

pjenvey opened this issue Oct 9, 2018 · 0 comments
Assignees
@pjenvey

Comments

@pjenvey
Copy link
Member

pjenvey commented Oct 9, 2018

Passing collection_ids was somewhat inherited from the go version and additionally I missed the python version's handling of collection_ids via its global collection_id cache. Now that this cache is in place it makes sense to switch the higher level db interface to take collection names as Strings everywhere.

This also saves the handlers an extra future callback they'd need to make by pushing it down into the db layer
@pjenvey pjenvey self-assigned this Oct 9, 2018
pjenvey added a commit that referenced this issue Oct 10, 2018
@pjenvey
feat: push collection id lookup down into the db layer
21038cb 
Closes #57
@pjenvey pjenvey mentioned this issue Oct 10, 2018
Merged
pjenvey added a commit that referenced this issue Oct 10, 2018
@pjenvey
fix: add get_or_create_collection_id for put/post_bso
b44f973 
and ensure collection gets/creates cache their results

update hawk to quiet its stray println

Issue #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjenvey