feat: fix extractors, middleware for e2e tests #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
feat/issue-97
branch
3 times, most recently
from
ffdaa0b
to
f0718e8
Compare
pjenvey
requested changes
Nov 29, 2018
| }; | ||
| // Verify all the keys are valid | ||
| let valid_keys = ["id", "sortindex", "payload", "ttl"]; | ||
| for key_name in map.keys() { |
There was a problem hiding this comment.
nit this could be a one liner any()
There was a problem hiding this comment.
I guess I'm feeling dense as I'm not seeing what would be needed to make that happen.
bbangert
force-pushed
the
feat/issue-97
branch
from
f0718e8
to
dab93ad
Compare
pjenvey
reviewed
Nov 29, 2018
bbangert
force-pushed
the
feat/issue-97
branch
from
dab93ad
to
20e4373
Compare
pjenvey
reviewed
Nov 29, 2018
bbangert
force-pushed
the
feat/issue-97
branch
2 times, most recently
from
cb7dc91
to
85aa96a
Compare
pjenvey
reviewed
Nov 30, 2018
pjenvey
previously approved these changes
Nov 30, 2018
Extractors now use proper limits from the state object. BSO handling during deserialization/validation matches Python more closely. Closes #97
bbangert
force-pushed
the
feat/issue-97
branch
from
85aa96a
to
f172d28
Compare
pjenvey
approved these changes
Nov 30, 2018
This was referenced Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extractors now use proper limits from the state object. BSO handling
during deserialization/validation matches Python more closely.
Closes #97