Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vendored SDK to use protobuf 2.16.2 #747

Merged
merged 2 commits into from Jul 29, 2020

Conversation

jrconlin
Copy link
Member

Description

Update vendored mozilla-sdk to match hand-off.

Testing

N/A

Issue(s)

chore

AzureMarker
AzureMarker previously approved these changes Jul 28, 2020
pjenvey
pjenvey previously approved these changes Jul 28, 2020
@jrconlin jrconlin dismissed stale reviews from pjenvey and AzureMarker via 0d99c9a July 29, 2020 01:30
@@ -3,3 +3,5 @@ members = [
"googleapis",
"googleapis-raw",
]

# ci kick -- can be deleted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a restart build button on Travis and Circle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is, but for some stupid reason, I don't believe that Circle got the webhook notice that anything was pending. I looked on the circle task list and there was nothing.

Fun of complex, interwoven systems. Lots of room for stuff to break in fun ways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a way to tell GitHub to resend the webhook, if you have access to the repo settings.

@jrconlin jrconlin merged commit 39519bb into master Jul 29, 2020
@AzureMarker AzureMarker deleted the chore/update_mozilla-sdk branch July 29, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants