bug: normalize id elements to remove potential wrap characters #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove potential "{}" wrapper from bsoids and collection ids. (See original issue for details)
Test included.
Try sending in a sync request with a bso_id wrapped and URLencoded.
Closes #680
|
Do these changes depend on |
|
This is probably just an aspect of my local build. Right now, I can't build or test this PR without #747 without doing a good deal of work to fish out the various interdependencies. |
AzureMarker
reviewed
Jul 28, 2020
pjenvey
previously requested changes
Jul 28, 2020
|
So, reworked things to urldecode the bso_ids. Granted, now part of me is wondering if we should filter on those to prevent potential exploits by including high values. |
AzureMarker
reviewed
Jul 29, 2020
AzureMarker
reviewed
Jul 29, 2020
AzureMarker
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove potential "{}" wrapper from bsoids and collection ids. (See original issue for details)
Blocks on #747
Testing:
Test included.
Try sending in a sync request with a bso_id wrapped and URLencoded.
Issues:
Closes #680