Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows build doc #1895

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Add Windows build doc #1895

merged 1 commit into from
Feb 26, 2019

Conversation

carlfm01
Copy link
Collaborator

Please suggest any changes.

@ghost
Copy link

ghost commented Feb 20, 2019

No Taskcluster jobs started for this pull request 
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

carlfm01
carlfm01 commented Feb 20, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
lissyx
lissyx requested changes Feb 20, 2019
View reviewed changes
Copy link
Collaborator

@lissyx lissyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but I think the biggest missing point is "how do I build native_client on Window ?"

README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Show resolved Hide resolved
examples/net_framework/README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Show resolved Hide resolved
reuben
reuben reviewed Feb 21, 2019
View reviewed changes
examples/net_framework/README.md Outdated Show resolved Hide resolved
examples/net_framework/README.md Outdated Show resolved Hide resolved
kdavis-mozilla
kdavis-mozilla approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @lissyx and @reuben caught most of the issues and once those are addressed, I think it's fine.

The only nit for me is the location of the text pointing to the README for the windows build. I added a suggested place to move that text.

README.md Outdated Show resolved Hide resolved
@carlfm01
Copy link
Collaborator Author

carlfm01 commented Feb 23, 2019 •
edited
Loading

Please review the past points @reuben @lissyx . I wish I could test with more configurations but I just can't, it literally takes hours on my 6 core vm.

@lissyx
Copy link
Collaborator

lissyx commented Feb 26, 2019

Thanks @carlfm01 !

@lissyx lissyx merged commit 4689a30 into mozilla:master Feb 26, 2019
@carlfm01 carlfm01 deleted the windows-docs branch February 26, 2019 14:00
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reuben reuben reuben left review comments

@lissyx lissyx lissyx approved these changes

@kdavis-mozilla kdavis-mozilla kdavis-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlfm01 @lissyx @reuben @kdavis-mozilla