This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Changes since last review for fx peer review #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing browser.safebrowsing.provider.mozilla.lists pref
All users will see the "Content Blocking" onboarding
access setTimeout properly
New branch
Add icon to addon for about:addons.
This introduces a new attribute on the tabInfo called "payloadWaitingForSurvey", which keeps a payload that is currently held back from sending because the user still needs to respond to the reload survey. During testing I have also found that the onBeforeUnload event tends to be unreliable in certain cases (mostly when closing tabs), so this patch further makes onUnload record data as well.. It was necessary to send some of it along anyway, because the Browser:Reload event seems to arrive after onbeforeunload and so we need to send it in onunload. Sorry for the mess.
Make the reload survey apply to the document that was actually reloaded.
Follow-up fixes to #124
From my testing, getting the document from the event target of the unload event is more reliable than accessing the document getter on the docShell. I'm not sure why the docShell loses this property earlier, but it makes sense to use the event target since this is a web API and should have more stability guarantees than our internal docShell.
Disable the FastBlock limit explicitly in all branches.
Get the document from the unload event instead of the docShell
remove testing flag, increment version number
Allow survey to be shown on the same tab again after navigation
Fixes #137. _(Message COC002)_
Add Mozilla Code of Conduct
cknowles-admin
added
the
ARCHIVED - http://mzl.la/ghe-archive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be fairly straightforward...