Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons don't work #81

Closed
jbyun opened this issue Apr 30, 2015 · 15 comments
Closed

Colons don't work #81

jbyun opened this issue Apr 30, 2015 · 15 comments

Comments

@jbyun
Copy link

jbyun commented Apr 30, 2015

Just noticed this while using the font but colons are rendered as periods. Seems to be the case on the type tester at http://www.carrois.com/en/fira-4-1/ as well.

screen shot 2015-04-30 at 11 56 29 am
screen shot 2015-04-30 at 11 59 20 am

@michaelwu
Copy link

What browser / OS? Renders ok here on Linux Firefox nightly.

@jbyun
Copy link
Author

jbyun commented Apr 30, 2015

Looks like it's only on Chrome (42.0.2311.90) in OSX (tried in 10.10.3 and 10.9)

@jfkthame
Copy link
Contributor

This looks like it's probably a Chrome bug. The same problem occurs with several other characters that are composed (in the TrueType version) of two or more copies of the same "component" glyph: try " ‖ „ …

@jbyun
Copy link
Author

jbyun commented Apr 30, 2015

Ahh.. yeah those don't work either. Can this be fixed? 😕

@jfkthame
Copy link
Contributor

Actually, I think this is a font bug, not a Chrome bug.

Looking at the colon glyph in a TTX dump, for example:

<TTGlyph name="colon" xMin="50" yMin="-12" xMax="189" yMax="127">
  <component glyphName="period" x="0" y="0" flags="0x0"/>
  <component glyphName="period" x="0" y="368" flags="0x0"/>
  <instructions><assembly>
      PUSHB[ ]  /* 2 values pushed */
      1 1
      PUSHW[ ]  /* 1 value pushed */
      368
      PUSHB[ ]  /* 1 value pushed */
      48
      CALL[ ]
    </assembly></instructions>
</TTGlyph>

The bounding box in the glyph data here does not account for the second (shifted) component glyph.

I guess this is a bug in Glyphs.app, assuming that's what is being used to create the TTF files.

@jfkthame
Copy link
Contributor

@carrois, can you look into this, and report to Georg if it's confirmed as a Glyphs bug?

@carrois
Copy link

carrois commented May 4, 2015

We talked to Georg – this seems to be a known issue for some browsers under some circumstances. But he finally found a way to solve it within the export process.
Will be fixed within the next update!

@ Patryk: are there any further issues for this update except from the Gaelic ampersand?!
If not, we can deliver 4.101 by the end of the week when the fixed version of Glyphs is available.

@jfkthame
Copy link
Contributor

I don't think this is fixed yet in 4.101: dumping the 'glyf' table shows the "colon" glyph unchanged as

<TTGlyph name="colon" xMin="50" yMin="-12" xMax="189" yMax="127">
  <component glyphName="period" x="0" y="0" flags="0x0"/>
  <component glyphName="period" x="0" y="368" flags="0x0"/>
  <instructions><assembly>
      PUSHB[ ]  /* 2 values pushed */
      1 1
      PUSHW[ ]  /* 1 value pushed */
      368
      PUSHB[ ]  /* 1 value pushed */
      48
      CALL[ ]
    </assembly></instructions>
</TTGlyph>

which still has an incorrect bounding box.

@carrois
Copy link

carrois commented May 12, 2015

Think we have address that to Georg once more.

@carrois
Copy link

carrois commented May 12, 2015

I just tried to fix that by decomposing /colon. Please download the files once more.
But since there are many glyphs using multible components of one base glyph I don't see that is the solution for that matter. I already adressed it to the Glyphs developer team.

@carrois
Copy link

carrois commented May 13, 2015

screenshot
A quick check by Georg.
Could you please check the lates version, too? Please redownload from our website.
Thanks.

@jfkthame
Copy link
Contributor

I just re-downloaded, and checked a few of the glyphs. In this version, it appears that ALL composites have been decomposed in the TTF version (whether or not they were affected by the bug).

So this version should work around the rendering problem -- the glyphs now have correct bounding boxes, AFAICS -- but it's a workaround rather than a proper fix, and it means the resulting TTF files are substantially larger than they should be. (E.g. FiraSans-Regular.ttf has grown from 405868 bytes to 592288 bytes, an increase of 45% ... ouch!)

Please press Georg to actually fix the underlying bug, rather than just decomposing everything to avoid it, so that TTF fonts with components can be correctly generated.

@carrois
Copy link

carrois commented May 13, 2015

Just updated to 4.102 and Mono 3.202 exported by Glyphs build 744.
Please try that verison and please report if #81 is fixed now.
Thanks for your patience!

@jfkthame
Copy link
Contributor

Yes, this appears to fix the bounding box issue, and these glyphs no longer get clipped in some applications. Thanks!

I notice that the "colon" glyph in Fira Sans is still the decomposed version; now that the composite export bounding-box bug is fixed, you can presumably revert this and keep the composite glyph here.

@jfkthame
Copy link
Contributor

Looks OK now in 4.103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants