Add handling of securitygroups in cloudtrail plugin

mozilla · Mar 15, 2018 · 3445ebd · 3445ebd
1 parent 378c3d1
commit 3445ebd
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/mq/plugins/cloudtrail.py b/mq/plugins/cloudtrail.py
@@ -99,6 +99,14 @@ def onMessage(self, message, metadata):
                         'raw_value': str(endpoint_str)
                     }
 
+            # Handle details.responseelements.securityGroups strings
+            if 'securityGroups' in message['details']['responseelements']:
+                securityGroups_str = message['details']['responseelements']['securityGroups']
+                if type(securityGroups_str) is not dict:
+                    message['details']['responseelements']['securityGroups'] = {
+                        'raw_value': str(securityGroups_str)
+                    }
+
         # Handle details.additionaleventdata strings
         if 'additionaleventdata' in message['details']:
             additionaleventdata_str = message['details']['additionaleventdata']

diff --git a/tests/mq/plugins/test_cloudtrail.py b/tests/mq/plugins/test_cloudtrail.py
@@ -284,3 +284,27 @@ def test_ebs_optimized(self):
         }
         assert retmessage == expected_message
         assert retmeta == {}
+
+    def test_securityGroups(self):
+        msg = {
+            'source': 'cloudtrail',
+            'details': {
+                'responseelements': {
+                    'securityGroups': 'astringvalue',
+                }
+            }
+        }
+        (retmessage, retmeta) = self.plugin.onMessage(msg, {})
+
+        expected_message = {
+            'source': 'cloudtrail',
+            'details': {
+                'responseelements': {
+                    'securityGroups': {
+                        'raw_value': 'astringvalue',
+                    }
+                }
+            }
+        }
+        assert retmessage == expected_message
+        assert retmeta == {}