fix Play Store feature filtering #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <uses-feature android:name="android.hardware.wifi" /> | ||
| <uses-feature android:name="android.hardware.location.gps" android:required="true" /> | ||
| <uses-feature android:name="android.hardware.telephony" android:required="false" /> | ||
| <uses-feature android:name="android.hardware.wifi" android:required="false" /> |
There was a problem hiding this comment.
no wifi? I can't imagine we support a no wifi device
There was a problem hiding this comment.
I don't know which devices those might be, but wouldn't it be the same as scanning with wifi disabled? Or is there a problem that will crash the app?
There was a problem hiding this comment.
Let's leave that one out since we are unsure of the implications.
There was a problem hiding this comment.
It would crash... could be fixed of course in case that is needed at some point.
Updated push to minimum changes.
|
Looks good! |
garvankeeley
added a commit
that referenced
this pull request
Oct 31, 2014
@cascheberg fix Play Store feature filtering: telephony not required
|
@cascheberg is Wi-Fi now required or not? |
|
wifi is required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1150.
@garvankeeley Just saw that you found the same cause.