Wait for the crash stats home page to finish loading

[davehunt]

This addresses the current failures, most likely caused by Selenium clicking too soon.

Adhoc: http://webqa-ci-staging1.qa.scl3.mozilla.com:8080/job/socorro.adhoc/43/

[m8ttyB]

I'm not familiar with return self? What does this do?

[davehunt]

It returns the page object. It's not essential or even used in this patch, I've just been using it in recent projects. It allows for executing code like:

page = MyPage(self.testsetup).wait_for_page_to_load()

Instead of:

page = MyPage(self.testsetup)
page.wait_for_page_to_load()

[m8ttyB]

I like this approach. One additional question, have we standardized on moving the wait_for_page_to_load() out of the constructor?

[davehunt]

There's a bit of inconsistency between our suites on this. Recently I have been explicitly implementing this wait method and an open method so that instantiation is not tied with any interactions. This allows us to wait for the page to load even if we're creating it as a result of calling a method in another page object, instead of opening the page directly.

I intend to standardise this in the future by offering a page object model package that can be used and extended by our suites.

On 23 Nov 2015, at 19:33, Matt Brandt notifications@github.com wrote:

In pages/home_page.py:

@@ -24,6 +26,13 @@ def init(self, testsetup, product=None):

     if product is None:
         self.selenium.get(self.base_url)

•    self.wait_for_page_to_load()
  
• def wait_for_page_to_load(self):

•    Wait(self.selenium, self.timeout).until(
  

•        lambda s: 'loading' not in s.find_element(
  

•            *self._graph_locator).get_attribute('class'))
  

•    return self
  

  I like this approach. One additional question, have we standardized on moving the wait_for_page_to_load() out of the constructor?

—
Reply to this email directly or view it on GitHub.

[m8ttyB]

r+ and woot for battling the stability gremlins