Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You should be able to drag orphaned nodes onto another node. #54

Closed
brianpeiris opened this issue Jul 13, 2018 · 3 comments
Closed

You should be able to drag orphaned nodes onto another node. #54

brianpeiris opened this issue Jul 13, 2018 · 3 comments
Labels
enhancement work that enhances an existing feature
Projects
alpha

Comments

@brianpeiris
Copy link
Contributor

After #52, orphaned nodes are displayed in the hierarchy, but you cannot move or modify them. Perhaps users should be able to move them under valid nodes.
@brianpeiris brianpeiris added the enhancement work that enhances an existing feature label Jul 13, 2018
@brianpeiris brianpeiris added this to To do in alpha via automation Jul 13, 2018
@tony056 tony056 mentioned this issue Jul 13, 2018
Closed
@tony056 tony056 moved this from To do to In progress in alpha Jul 13, 2018
@tony056 tony056 self-assigned this Jul 13, 2018
@tony056
Copy link
Contributor

tony056 commented Jul 17, 2018 •
edited

Is it ok that I only enable children under the missing root since we haven't came up with a solution for the duplicate nodes situation in #57?

@brianpeiris
Copy link
Contributor Author

I'm not sure how this relates to duplicate nodes, but yes, I imagine you should only be able to move the children, not the missing root itself.

@tony056 tony056 moved this from In progress to Needs review in alpha Jul 18, 2018
@tony056
Copy link
Contributor

tony056 commented Jul 19, 2018

PR #59

@tony056 tony056 closed this as completed Jul 19, 2018
alpha automation moved this from Needs review to Done Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement work that enhances an existing feature
Projects
No open projects
alpha
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianpeiris @tony056