warning displays - renamed/deleted nodes in the inherited scene file #52
Conversation
| <path id="Path_1" data-name="Path 1" class="cls-1" d="M8,16a8,8,0,1,1,8-8,8,8,0,0,1-8,8ZM8,2a6,6,0,1,0,6,6A6,6,0,0,0,8,2Z"/> | ||
| <path id="Path_2" data-name="Path 2" class="cls-1" d="M8,7A1,1,0,0,0,7,8v3a1,1,0,0,0,2,0V8A1,1,0,0,0,8,7Z"/> | ||
| <circle id="Ellipse_1" data-name="Ellipse 1" class="cls-1" cx="1.188" cy="1.188" r="1.188" transform="translate(6.812 3.812)"/> | ||
| </svg> |
There was a problem hiding this comment.
Where are these icons from? We we need to provide attribution?
There was a problem hiding this comment.
Assets are from here: https://design.firefox.com/icons/viewer/
It's open for everyone to download. I didn't see anything about attribution, but I might missed it. Let me know if you see something about attribution.
There was a problem hiding this comment.
Ah, cool. Um, I suppose technically these are licensed under MPL, but I think we're good since it's internal.
src/client/editor/SceneLoader.js
Outdated
| parentObject = new THREE.Object3D(); | ||
| parentObject.name = entity.parent; | ||
| parentObject.isMissingRoot = true; | ||
| parentObject.missing = true; |
There was a problem hiding this comment.
isMissingRoot and missing should be on parentObject.userData and should start with an underscore.
src/client/ui/SnackBar.js
Outdated
| duplicate: { | ||
| img: warningIcon, | ||
| content: "Duplicate node names in your gltf modals.", | ||
| helpURL: "https://github.com/MozillaReality/hubs-editor/wiki/Tutorials" |
There was a problem hiding this comment.
Maybe just create a couple of placeholder wiki pages now.
| })} | ||
| onMouseUp={e => this.onMouseUpNode(e, node)} | ||
| onMouseUp={node.object.missing ? undefined : e => this.onMouseUpNode(e, node)} | ||
| onMouseDown={node.object.missing ? e => e.stopPropagation() : undefined} |
There was a problem hiding this comment.
Hmm, would null work here instead of undefined? I think we prefer using null in code.
src/client/editor/SceneLoader.js
Outdated
| scene.conflicts = { | ||
| missing: false, | ||
| duplicate: false | ||
| }; |
There was a problem hiding this comment.
conflicts should be under scene.userData and should start with an underscore.
| return; | ||
| } | ||
| const conflicts = this.props.editor.scene.conflicts; | ||
| console.log(Object.keys(conflicts)); |
There was a problem hiding this comment.
Remove the console.log
| align-content: space-between; | ||
| flex-wrap: wrap; | ||
| position: absolute; | ||
| width: 80%; |
There was a problem hiding this comment.
Hmm, I'm not sure about using percentages. I think we use fixed pixels everywhere else.
src/client/ui/SnackBar.js
Outdated
| const conflictTypes = { | ||
| missing: { | ||
| img: errorIcon, | ||
| content: "Missing nodes in your .scene file.", |
There was a problem hiding this comment.
Should this be "Missing nodes in inherited GLTF"?
warning displays - renamed/deleted nodes in the inherited scene file
SnackBar.jsto display different types of conflicts.SceneLoader.js.HeirarchyPanelContainer.js.