Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

Revamp UI and responsiveness #63

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Revamp UI and responsiveness #63

merged 1 commit into from
Sep 19, 2016

Conversation

comzeradd
Copy link
Contributor

@comzeradd
Copy link
Contributor Author

@nukeador can you test it locally before we merge?

@nukeador
Copy link

  • breadcumbs class is now too small
  • Social icons to share don't have now a place to "hang from" since we removed the container side border
  • Localized pages need class update too
  • I'm not sure about this blue/purple colour for header, links. It's not very mozilla to me.

Cheers.

@comzeradd
Copy link
Contributor Author

Thanks. I hadn't touch the subpages yet. I just amended the commit to address these issues.

Regarding the header, I followed the color scheme of the branding graphics created for the stickers & t-shirts.

@nukeador
Copy link

If we want a dark blue colour we should check the sandstone palette

https://www.mozilla.org/en-US/styleguide/websites/sandstone/colors/

@nukeador
Copy link

I think #3F4B73 is way nicer for the dark blue

nightly-blue darkener 15% from https://mozilla.github.io/mofo-bootstrap/demo/

@comzeradd
Copy link
Contributor Author

A screenshot with the #3F4B73 version

screen shot 2016-09-19 at 11 20 01

@nukeador
Copy link

I still see this PR using the old colours. The rest seems to be fixed.

@comzeradd
Copy link
Contributor Author

I just amended the commit with the new colors.

@nukeador
Copy link

Great work, look awesome, it's good to merge.

Question: I don really get what the favicon is :P

* Make better use of grid css classes
* Collapse navbar to a hamburger button for mobile
* Fix responsivness issues
* Removed unused html/css code
* Switch to Fira Sans
* Add basic branding graphics
* Add License
@comzeradd
Copy link
Contributor Author

It's the rocket logo from the stickers design. But indeed it doesn't look that small. I reverted and we can revisit later.

@comzeradd comzeradd merged commit 1030c07 into mozilla:gh-pages Sep 19, 2016
@comzeradd comzeradd deleted the ui-revamp branch September 19, 2016 14:39
@brianking
Copy link
Contributor

Since the checkin, many pages on the site are redirecting to the mozilla.github.io version if the site, e.g. FAQ.

@umeshagarwal
Copy link

Just wanted to add my one cent to this work..
The "FAQ ROADMAP PARTICIPATION" on the top is little overlapping and has some rendering issue.
It will be great if it looks more clear.
I just visited all major sub links and it looks great to me!!

screen shot 2016-09-19 at 11 06 11 pm

@nukeador
Copy link

@brianking that should be fixed by f692ffe as soon as the cache is renewed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants