This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
feat(mc) #2837 Add snippets stuff #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarracini
approved these changes
Jul 17, 2017
|
|
||
| // Note that injecting snippets can throw if they're invalid XML. | ||
| if (containerEl) { | ||
| containerEl.style.display = "block"; |
| @@ -0,0 +1,261 @@ | |||
| const DATABASE_NAME = "abouthome"; | |||
There was a problem hiding this comment.
maybe rename to aboutnewtab?
| @@ -8,6 +8,10 @@ | |||
| </head> | |||
| <body class="activity-stream"> | |||
| <div id="root"></div> | |||
| <div id="topSection"></div> | |||
There was a problem hiding this comment.
just add a comment here about why it's needed, since this sounds important 😅
system-addon/lib/SnippetsFeed.jsm
Outdated
| } | ||
| onAction(action) { | ||
| switch (action.type) { | ||
| case at.INIT: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initial implementation of snippets integration. It currently works with the v4 snippets endpoint (although it looks a bit weird). Remaining issues:
Closes #2013 and #2837