This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
feat(topstories): Get new recommendations on locale|options change #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
approved these changes
Jul 31, 2017
|
|
||
| init() { | ||
| try { | ||
| this.storiesLastUpdated = 0; | ||
| this.topicsLastUpdated = 0; |
There was a problem hiding this comment.
This whole try block is a bit odd in that various things that don't need to be inside are. E.g., this assignments really shouldn't be throwing.
Don't need to fix now, but what are we actually expecting to fail? I could see JSON.parse failing.. anything else?
There was a problem hiding this comment.
@Mardak true, nothing else throwing here anymore. so, the scope is too wide. It's really about catching invalid JSON in .options.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3021, fixes #3000, by making sure the feed re-initializes when its options have changed.
This also includes the refactoring to no longer read the locale from within the TopStoriesFeed.