fix(topstories): Ctrl-click/middle mouse button does not open new tab #3046
Conversation
| this.props.dispatch(ac.SendToMain({type: at.OPEN_LINK, data: this.props.link})); | ||
| this.props.dispatch(ac.SendToMain({ | ||
| type: at.OPEN_LINK, | ||
| data: Object.assign(this.props.link, {where: (event.ctrlKey || event.metaKey || event.button === 1) ? "tab" : "current"}) |
There was a problem hiding this comment.
So this supports "tab" but not the other click behaviors, e.g., "window" (on shift) and "save" (on alt) or other behaviors supported in whereToOpenLink:
https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#111-159
Not sure if there's a good way to just send the event over to call that method on the browser.
There was a problem hiding this comment.
Yeah, I didn't find one :(. We have support for "window" though via the context menu (not shortcut) (incl. private windows).
I think this is better than not having it for 56, but I will leave it up to you guys. I am fine either way and can dig in more.
There was a problem hiding this comment.
Looks like you could callbrowser.ownerGlobal.whereToOpenLink with the event, if you can pass the whole event up
There was a problem hiding this comment.
A fake event should work to get across the message boundary:
const {altKey, button, ctrlKey, metaKey, shiftKey} = event;
dispatch({…
data: … {event: {altKey, button, ctrlKey, metaKey, shiftKey}, …}There was a problem hiding this comment.
@Mardak ah I will try that. Was just looking for ways to get the event across again.
| this.props.dispatch(ac.SendToMain({type: at.OPEN_LINK, data: this.props.link})); | ||
| this.props.dispatch(ac.SendToMain({ | ||
| type: at.OPEN_LINK, | ||
| data: Object.assign(this.props.link, {where: (event.ctrlKey || event.metaKey || event.button === 1) ? "tab" : "current"}) |
There was a problem hiding this comment.
Looks like you could callbrowser.ownerGlobal.whereToOpenLink with the event, if you can pass the whole event up
|
OK, I can give it another try. |
|
@Mardak @k88hudson thanks, updated. |
Fixes #3033.