This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
fix (systemaddon): #3051 update to tippy top v1.3.1 (default sites only) #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
approved these changes
Aug 1, 2017
There was a problem hiding this comment.
side note: is the json somewhat made by hand? The urls array is not sorted, e.g., amazon's. And looks like we don't use domain. bbc.com and ebay.com are included, but I guess that's fine as we need them for other locales. Also youtube comes before the "w"s, e.g., wikipedia in that json.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3051. This version of tippy-top-sites only has the 16 sites that are included in our default top sites list. See https://github.com/mozilla/tippy-top-sites/blob/v1.3.1/top_sites.json
r? @Mardak