Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

chore(bootstrap): Backport Preferences -> Services.prefs change from bug 1357517 #3067

Merged
merged 1 commit into from
Aug 2, 2017
Merged

chore(bootstrap): Backport Preferences -> Services.prefs change from bug 1357517 #3067

merged 1 commit into from
Aug 2, 2017

Conversation

Mardak
Copy link
Member

@Mardak Mardak commented Aug 1, 2017

Fix #3065. r?@dmose Just applied the patch directly then fixed 2 eslint issues: no-use-before-define (can't fix as observe calls both onBrowserReady and onPrefChanged). and == vs ===

@Mardak Mardak requested a review from dmose August 1, 2017 23:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.407% when pulling f30b605 on Mardak:gh3065-backport into 9a32100 on mozilla:master.

dmose
dmose approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@dmose dmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=dmose

@dmose dmose merged commit 8d800d6 into mozilla:master Aug 2, 2017
@as-pine-proxy
Copy link
Collaborator

Treeherder: c99263e3d5d4aec9a7a09c8cb9e281298095a578

@Mardak Mardak deleted the gh3065-backport branch August 2, 2017 03:23
@Mardak Mardak mentioned this pull request Sep 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmose dmose dmose approved these changes

Assignees

@dmose dmose

Labels
PR / Needs review pushed-to-pine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport Bug 1357517 - Remove Preferences.jsm usage from some browser/extensions/ modules. r=Gijs
5 participants
@Mardak @coveralls @as-pine-proxy @dmose @marco-c