Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Bug 1546733 - [Card] Place source above title and adjust vertical spacing #4999

Merged
merged 2 commits into from
May 8, 2019

Conversation

gvn
Copy link
Contributor

@gvn gvn commented May 8, 2019

QA: Run dev-test-all layout and compare to requests in 1546733

@ScottDowne
Copy link
Collaborator

Putting that link at the bottom had some flexbox usage to do right.

Do we still need it? I'm wondering if we can kill them. I see:

.ds-card-link with:

display: flex;
flex-direction: column;
justify-content: space-between;

and .meta with:

display: flex;
flex-direction: column;
flex-grow: 1;

The above was only there to make that soure text float on the bottom of the card, I think.

Also, .info-wrap has a margin: 0 0 12px; and flex-grow: 1; that I wonder if we still need.

Copy link
Collaborator

@ScottDowne ScottDowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+if you file a followup for 69 to cleanup dead css.

@gvn gvn merged commit b7b9310 into mozilla:master May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants