bug fix: need to make sure that numeric default values for prefs are …

…integers
mozilla · Nov 19, 2011 · 299ec79 · 299ec79
1 parent 10da2c0
commit 299ec79
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/python-lib/cuddlefish/app-extension/bootstrap.js b/python-lib/cuddlefish/app-extension/bootstrap.js
@@ -71,7 +71,8 @@ function setDefaultPrefs() {
           branch.setBoolPref(key, val);
           break;
         case "number":
-          branch.setIntPref(key, val);
+          if (value % 1 == 0) // number must be a integer, otherwise ignore it
+            branch.setIntPref(key, val);
           break;
         case "string":
           branch.setCharPref(key, val);

diff --git a/python-lib/cuddlefish/options_defaults.py b/python-lib/cuddlefish/options_defaults.py
@@ -7,7 +7,9 @@ def parse_options_defaults(options, jetpack_id):
             value = pref["value"]
             vtype = str(type(value))
 
-            if ("<type 'bool'>" == vtype):
+            if ("<type 'float'>" == vtype):
+                continue
+            elif ("<type 'bool'>" == vtype):
                 value = str(pref["value"]).lower()
             elif ("<type 'str'>" == vtype):
                 value = "\"" + str(pref["value"]) + "\""