Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

Commit

Permalink
Fix failing tests introduced by ba6e7ea
Browse files Browse the repository at this point in the history
  • Loading branch information
Gozala committed Apr 17, 2014
1 parent 13811db commit e98999d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 19 deletions.
23 changes: 12 additions & 11 deletions test/test-tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,19 +156,20 @@ exports["test viewFor(tab)"] = (assert, done) => {
tabs.open({ url: "about:mozilla" });
};

exports["test modelFor(xulTab)"] = (assert, done) => {
tabs.once("open", tab => {
const view = viewFor(tab);
assert.ok(view, "view is returned");
assert.ok(isTab(view), "view is underlaying tab");
assert.equal(getTabId(view), tab.id, "tab has a same id");
assert.equal(modelFor(view), tab, "modelFor(view) is SDK tab");

tab.close();
done();
exports["test modelFor(xulTab)"] = (assert, done) => {
tabs.open({
url: "about:mozilla",
onReady: tab => {
const view = viewFor(tab);
assert.ok(view, "view is returned");
assert.ok(isTab(view), "view is underlaying tab");
assert.equal(getTabId(view), tab.id, "tab has a same id");
assert.equal(modelFor(view), tab, "modelFor(view) is SDK tab");

tab.close(defer(done));
}
});

tabs.open({ url: "about:mozilla" });
};

require("test").run(exports);
12 changes: 4 additions & 8 deletions test/test-windows-common.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ exports.testWindowActivateMethod_simple = function(assert) {
'Active tab is active after window.activate() call');
};


exports["test getView(window)"] = function(assert, done) {
browserWindows.once("open", window => {
const view = viewFor(window);
Expand All @@ -69,16 +70,14 @@ exports["test getView(window)"] = function(assert, done) {
assert.equal(getWindowTitle(view), window.title,
"window has a right title");

window.close();
window.destroy();
assert.equal(viewFor(window), null, "window view is gone");
done();
window.close(done);
});


browserWindows.open({ url: "data:text/html;charset=utf-8,<title>yo</title>" });
};


exports["test modelFor(window)"] = function(assert, done) {
browserWindows.once("open", window => {
const view = viewFor(window);
Expand All @@ -87,10 +86,7 @@ exports["test modelFor(window)"] = function(assert, done) {
assert.ok(isBrowser(view), "view is a browser window");
assert.ok(modelFor(view) === window, "modelFor(browserWindow) is SDK window");

window.close();
window.destroy();
assert.equal(viewFor(window), null, "window view is gone");
done();
window.close(done);
});


Expand Down

0 comments on commit e98999d

Please sign in to comment.