onUntrack should be optional for the WindowTracker constructor in the window-utils module #197
Conversation
|
What is a use case for this ? When do you want to listen for onTrack without onUntrack ? |
|
When I use third-party apis to handle unloaders, example: https://github.com/erikvold/toolbarbutton-jplib/blob/master/lib/toolbarbutton.js#L123 |
|
To be honest I don't quite see why do you prefer listener on unload over onUntrack. Also have you seen The change itself looks ok, but then one might expect to make Let me know if you still want it even though there is |
If I use onUntrack then I would need to store an array of windows or windowIDs along with arrays of toolbar buttons used on the window, and event listeners used on the window, so that I could remove them when onUntrack is called, which takes longer to implement, seems more error prone, and harder to maintain. Also but I can't tell why onUntrack is called when it is called, which is helpful to know so that I don't do unnecessary work when a window is simply being closed. Lastly onUntrack is called from every window closed, and I have to write code that checks the location to make sure it's not a window that I care about. I'll replace the standard unload listener with a window ID based implementation soon too.
No I hadn't, I think I will write my own module though. |
|
In any case change looks, so r+ on it and I'm pulling it in.
I would not recommend going with that path, let's better improve APIs that are in SDK if they are not good enough |
onUntrack should be optional for the WindowTracker constructor in the window-utils module r=irakli
No description provided.