This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
fix bug 672443 - reuse compartments between module sandboxes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,14 +15,15 @@ const scriptLoader = Cc['@mozilla.org/moz/jssubscript-loader;1']. | |||
| getService(Ci.mozIJSSubScriptLoader); | |||
|
|
|||
| const Sandbox = { | |||
| new: function (prototype, principal) { | |||
| new: function ({ principal, prototype, name, existingSandbox }) { | |||
There was a problem hiding this comment.
I get following error about 'principal':
"reference to undefined property "principal""
I'm not an expert in object deconstruction, but it seems that all such attribute has to be set in the given object, otherwise we get this error.
ochameau
added a commit
that referenced
this pull request
Jan 10, 2012
fix bug 672443 - reuse compartments between module sandboxes and set sandboxName to the module URI r=@ochameau
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes bug 672443 by reusing compartments between module sandboxes created by an instance of the loader. It drastically reduces the number of entries for modules in about:memory?verbose when tested against the annotator example. It also happens to fix bug 680821, which is also being addressed by pull request 323. Since this pull request fixes both issues, it's the better one to merge.