Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 791577: Support "test addons" #575

Merged
merged 6 commits into from Oct 1, 2012

Conversation

Projects
None yet
2 participants
Member

ochameau commented Sep 16, 2012

More detail in bugzilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=791577

Note that this pull request is splitted in mutliple meaningfull commits in order to help the review.

Contributor

erikvold commented Sep 28, 2012

@ochameau the test l10n addon just hangs on Fennec. I made another add-on simple add-on for simple-prefs and that one works tho.

Member

ochameau commented Sep 28, 2012

The original l10n tests wasn't working on Fennec, because of PageWorker usage:
https://github.com/erikvold/jetpack-sdk/blob/8c57bacb22e7f42b514bee5d26f503cdb395dec0/test-addons/l10n/main.js#L97

Member

ochameau commented Sep 28, 2012

Would you mind addressing this in a followup patch, as it isn't related to this feature?

Contributor

erikvold commented Sep 28, 2012

sure
r+

@ochameau ochameau added a commit that referenced this pull request Oct 1, 2012

@ochameau ochameau Merge pull request #575 from ochameau/tests-addons
Bug 791577: Support "test addons". r=@gozala
57ca4fe

@ochameau ochameau merged commit 57ca4fe into mozilla:master Oct 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment