Bug 816688 Output test messages in the tinderbox standard #669

Merged
merged 4 commits into from Jan 3, 2013

Conversation

Projects
None yet
2 participants
Member

Mossop commented Nov 30, 2012

I wasn't totally sure the best way to approach this, but this replaces the console for tests with a custom one that outputs lines in the expected format for tinderbox. Every test starts with TEST-START and ends with TEST-END, with TEST-INFO, TEST-PASS, TEST-KNOWN-FAIL, TEST-UNEXPECTED-FAIL and TEST-UNEXPECTED-PASS in between. Each line also includes the running test where possible.

Member

Gozala commented Dec 6, 2012

This looks fine, only thing is I would rather prefer if we had argument for a logging mode instead, so for humans output will remain same, but for tinderbox we could do something like cfx testall --parsable or something along that lines.

Also I could live with this output too.

Member

Mossop commented Dec 20, 2012

@Gozala I've updated this to add a --parseable flag to cfx that switches to the new logging format.

Member

Gozala commented Jan 3, 2013

@Mossop Looks good to me, only thing I'm not sure about is that in --parsable mode no stack traces are printed. Is that intentional ? Ability to see stacks traces on failures in tinderbox had being pretty useful, specially on ones that are hard to reproduce on local machine.

If printing stack traces makes sense please do so, otherwise feel free to land. Either way I don't think we need any more iterations on this.

Member

Mossop commented Jan 3, 2013

Oh that's not intentional, I'll make it output stacks before landing.

Mossop added a commit that referenced this pull request Jan 3, 2013

Merge pull request #669 from Mossop/bug816688
Bug 816688 - Output test messages in the tinderbox standard. r=@gozala

@Mossop Mossop merged commit 02e0eef into mozilla:master Jan 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment