This repository has been archived by the owner on Feb 26, 2022. It is now read-only.
Fix for bug 823928: the examples are not reflecting the new layout changes #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| There are more useful examples of this technique in the Jetpack Wiki's | ||
| collection of [third party modules](https://wiki.mozilla.org/Jetpack/Modules). | ||
|
|
||
| ### <a name="accessing-tabbrowser">Accessing <a href="https://developer.mozilla.org/en/XUL/tabbrowser">tabbrowser</a> ### | ||
|
|
||
|
|
||
| The [`tab-browser`](modules/sdk/deprecated/tab-browser.html) module gives | ||
| The [`tabs/utils`](modules/sdk/tabs/utils.html) module gives | ||
| you direct access to the |
There was a problem hiding this comment.
I'm not sure how much is correct saying "The tabs/utils module gives you direct access to the tabbrowser object and the XUL tab objects it contains" Where is true that you can use the tabs/utils to do that, the sentence seems imply it's actually the only thing you can do – where it was true with the old tab-browser module, but not for the tabs/utils.
|
Looks good to me! Added some comments, nothing blocking however. r+ |
wbamberg
pushed a commit
that referenced
this pull request
Jan 17, 2013
Fix for bug 823928: the examples are not reflecting the new layout changes
wbamberg
pushed a commit
to wbamberg/jetpack-sdk
that referenced
this pull request
Jan 18, 2013
Fix for bug 823928: the examples are not reflecting the new layout changes(cherry picked from commit 06c9965)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated all the require statements that I found, and smoke-tested all the examples that were fairly easily executable. In doing that I found a few other bugs in the examples, and fixed those. I've also updated examples that used deprecated modules like window-utils to make them use the replacements.