-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a Skeleton component #606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
=========================================
+ Coverage 98.16% 98.2% +0.04%
=========================================
Files 42 43 +1
Lines 1087 1112 +25
Branches 243 254 +11
=========================================
+ Hits 1067 1092 +25
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @willdurand. Just one nit/question.
r+wc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started. There are higher priority items but I agree with what you mentioned that we are investing more code debt in non-skeletonized components each day.
I would say just hold off on skeletonizing all the existing components because that will take a lot of time and I'd like to make some headway on the comments work first. However, we should try to skeletonize new components after you land this 🎉
Sorry for the late review. I think some of my comments are worth following up on. |
I thought I left such a comment somewhere.. I totally agree and that was my plan too. |
Fixes #607
Fixes #608
Supports #379
This is a very simple
Skeleton
component that should fill the place where it is added. We can iterate if we need to add constraints (likerange
andminWidth
props) but it's only the beginning of the long journey to fix #379.The second commit refactors the
VersionChooser
component to see theSkeleton
in action: