Update caching docs now that we're on the CDN #10967
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Looks good, thanks @diox. I have a couple of questions and a couple of suggestions.
r+wc
| Caching is bypassed if a request comes in with any of the following: | ||
|
|
||
| - `frontend_auth_token` cookie (extracted from the Cookie header) | ||
| - `disable_caching` query parameter in the URL |
There was a problem hiding this comment.
Is it no longer possible to disable caching via a query parameter?
There was a problem hiding this comment.
No, this was never re-implemented. Sending a token cookie is enough.
|
|
||
| ### Cookies in responses | ||
|
|
||
| In addition to what's described above, Nginx is currently configured to never cache a response containing the `Set-Cookie` header. This is a safety measure that we could deactivate if needed. The value of the `Set-Cookie` header wouldn't affect the cache key. |
There was a problem hiding this comment.
Has the limitation of not being able to set cookies on the server been eliminated with the move to the CDN?
There was a problem hiding this comment.
Yes and no. Previously setting cookies would cause the response not to be put in the cache. Now that limitation is gone, but it's potentially dangerous, since the response will be put in the cache with the Set-Cookie that was sent by the origin, so any future client request might get served that response (and those cookies) by the CDN.
No description provided.