Ensure installURL is set before calling withInstallHelpers #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Nov 21, 2016
| @@ -160,6 +160,7 @@ | |||
| "bunyan": "1.8.5", | |||
| "camelcase": "4.0.0", | |||
| "classnames": "2.2.5", | |||
| "common-tags": "^1.4.0", | |||
mstriemer
force-pushed
the
addon-install-fails-4035
branch
from
11f10da
to
f234af3
Compare
Fixes mozilla/addons-server#4035
mstriemer
force-pushed
the
addon-install-fails-4035
branch
from
30a4bd1
to
600219a
Compare
|
Superseded by mozilla/addons#2377. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The props weren't getting set for the updated
withInstallHelpersHOC so it was failing on install. I made it throw now if it is misconfigured.Just had to reorder the
compose()inAddonto fix this.Fixes mozilla/addons#3770.