-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change extension workshop urls when running dev #7845
Conversation
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#7845 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.01%
==========================================
Files 257 259 +2
Lines 7051 7101 +50
Branches 1312 1312
==========================================
+ Hits 6912 6962 +50
Misses 125 125
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks good. Could you please remove the bin/.gitattributes
file though?
@feugy not sure you receive notifications when a review has been made. Thanks for your work. I requested a minor change though :) |
@willdurand I got the notifs, I was just busy 😄 I've removed the .gitattributes file and updated the PR description. |
Yep, that's right but we try not to have too many generic files here. I believe one could configure windows globally instead. |
Thanks so much for the patch, @feugy! Your contribution has been added to our recognition wiki and your mozillians.org profile has been vouched. 🎉 Welcome onboard! I look forward to seeing you around the project. :) |
Thank you @caitmuenster & @willdurand! |
Fix mozilla/addons#13102
Description
When running
yarn dev:amo
, the link to extension workshop in footer now point at ttps://extensionworkshop-dev.allizom.org.Please note the url is not available 😢
I've also added.gitattribute
file to force LF end of lines on checkout. Developers withauto.crlf=true
in their global git configuration. One cannot run the app with CLRF in script files.Screenshot