Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extension workshop urls when running dev #7845

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Change extension workshop urls when running dev #7845

merged 3 commits into from
Apr 10, 2019

Conversation

feugy
Copy link
Contributor

@feugy feugy commented Apr 6, 2019

Fix mozilla/addons#13102


Description

When running yarn dev:amo, the link to extension workshop in footer now point at ttps://extensionworkshop-dev.allizom.org.
Please note the url is not available 😢

I've also added .gitattribute file to force LF end of lines on checkout. Developers with auto.crlf=true in their global git configuration. One cannot run the app with CLRF in script files.

Screenshot

image

@codecov-io
Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #7845 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    mozilla/addons-frontend#7845      +/-   ##
==========================================
+ Coverage   98.02%   98.04%   +0.01%     
==========================================
  Files         257      259       +2     
  Lines        7051     7101      +50     
  Branches     1312     1312              
==========================================
+ Hits         6912     6962      +50     
  Misses        125      125              
  Partials       14       14
Impacted Files Coverage Δ
src/amo/components/Routes/index.js 40% <0%> (ø) ⬆️
src/amo/pages/UserProfileEdit/index.js 100% <0%> (ø) ⬆️
src/amo/components/Header/index.js 100% <0%> (ø) ⬆️
src/core/api/index.js 100% <0%> (ø) ⬆️
...o/components/UserProfileEditNotifications/index.js 100% <0%> (ø) ⬆️
src/amo/api/users.js 100% <0%> (ø) ⬆️
src/amo/reducers/users.js 100% <0%> (ø) ⬆️
src/amo/sagas/users.js 100% <0%> (ø) ⬆️
src/amo/pages/UsersUnsubscribe/index.js 100% <0%> (ø)
src/amo/utils/notifications.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028fcb6...b3bb1ac. Read the comment docs.

Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good. Could you please remove the bin/.gitattributes file though?

@willdurand willdurand self-assigned this Apr 8, 2019
@willdurand
Copy link
Member

@feugy not sure you receive notifications when a review has been made. Thanks for your work. I requested a minor change though :)

@feugy
Copy link
Contributor Author

feugy commented Apr 9, 2019

@willdurand I got the notifs, I was just busy 😄

I've removed the .gitattributes file and updated the PR description.
I reckon that very few people will checkout the code on a NTFS partition. It's could be something to consider though, since Windows now have "real" bash and could run .sh files.

@willdurand
Copy link
Member

Yep, that's right but we try not to have too many generic files here. I believe one could configure windows globally instead.

@willdurand willdurand merged commit f7f36b8 into mozilla:master Apr 10, 2019
@caitmuenster
Copy link

Thanks so much for the patch, @feugy! Your contribution has been added to our recognition wiki and your mozillians.org profile has been vouched. 🎉

Welcome onboard! I look forward to seeing you around the project. :)

@feugy
Copy link
Contributor Author

feugy commented Apr 13, 2019

Thank you @caitmuenster & @willdurand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update -dev and local dev when EW gets a -dev env (if any)
4 participants