-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow use of "Mozilla" or "Firefox" in add-on names #2158
Comments
Thanks Jorge! What is the timeline for this? I assume there will be some kind of validation for any submission (both new add-ons and updates to existing ones). We need to keep in mind that updates with a changed name in the XPI does not automatically update the name on AMO. What will happen to existing add-ons that don't get updates? Will they be automatically updated by us? We need to keep potential conflicts in mind, e.g. when an add-on gets renamed from "Ad Blocking for Firefox", but there is already an "Ad Blocking" add-on listed. We also might want to add "Fire fox" to the list, since that is an easy workaround with a similar impact on SEO. |
Luckily the current validation happens directly on addons-server and not on the linter, so we should be able to distinguish between new submissions and updates in case we want to handle them differently. |
It's part of a Q4 project, but if anyone wants to tackle this before then, it should be fine.
Once the check is in place for submissions, we'll have to reach out to devs and give them some time to adjust. After that, we'll just change the names ourselves.
There are so many variations that I don't think we should try to cover them automatically.
@EnTeQuAk should I move this to addons-server then? |
Or, rather, should I also file an issue on addons-server? |
I guess both projects need a change, we currently don't have any checks in addons-linter regarding the trademark but eventually, we should warn developers ahead of time in case they're using disallowed add-on names. So yes, both would be nice. Thanks! |
@jvillalobos since the server-side changes are done and it appear based on mozilla/addons#5920 to not affect mozilla specific accounts presumably the change on the linter side should only be a warning? |
Yeah, as long as we block submission on addons-server (for non-Moz accounts), it should be okay to have the linter just warn about it. |
Firefox Color https://addons.mozilla.org/addon/firefox-color-prod/ |
This is already being enforced (my add-on can't have "for Firefox 57+" in the name), but the add-on policies page has not been updated. I just ran into this issue for an add-on and had search to find this issue here. |
Thanks @vaindil! I can look into updating this. |
The outstanding action here is to add warnings here in the linter. |
Is this still in the roadmap? Can i work on it? To make the proposed solution clear, it is necessary to create a new rule in linter to see if the extension name (property name in manifest.json) has the words |
I'm not sure if this issue is still relevant, because the add-on policies page has the below quote. I don't know if that has always been there though.
|
Yes
That's right. You might also need to check for localized versions of the name, but I don't know how complex that is to do on the linter. |
Just created mozilla/addons#3313 |
Is the add-on policies page ever going to be updated to reflect this? |
Probably, in a future update. |
This has been enforced for over a year now but the policies page hasn't been updated, that was why I asked. Thanks! |
@vaindil I can send a PR to from:
to:
do you think it is necessary to add some more information or is this good? |
Thanks, I appreciate the effort but we do not accept pull requests for changes to the policies page. There is a larger process involved, we will likely change that with our next planned update. |
see also mozilla/addons#7703 |
Up until now, we've allowed add-on names to end with "for Firefox" or "for Mozilla". For SEO reasons, we don't want to allow this anymore. Any use of those terms in add-on names should produce an error.
/cc @wagnerand to coordinate policy change when this lands.
The text was updated successfully, but these errors were encountered: