Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content-optimization waffle dependency for trademark checks. #7703

Closed
wagnerand opened this issue Jun 16, 2020 · 3 comments · Fixed by mozilla/addons-server#14660
Closed

Comments

@wagnerand
Copy link
Member

Describe the problem and steps to reproduce it:

The trademark check in https://github.com/mozilla/addons-server/blob/master/src/olympia/addons/utils.py#L32-L40 allows "... for Firefox" if the waffle switch content-optimization is turned off. We'd like to change that so it's disallowed regardless of the waffle switch.

STR:

  1. Have an existing add-on.
  2. Go to the developer hub and change the name to "Something for Firefox" or "Something for Mozilla".

What happened?

The add-on is successfully renamed.

What did you expect to happen?

An error should occur: Add-on names cannot contain the Mozilla or Firefox trademarks.

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

@jvillalobos
Copy link

Confirming that we're just closing the loop on the work done in mozilla/addons-linter#2158

@AlexandraMoga
Copy link

Verified fixed on -dev:

With the content-optimization waffle switch off, users are not able to submit an add-on that contains the terms (for) Mozilla or (for) Firefox in their names. The restriction also applies on the dev hub submission form[1] and in Edit product page[2]

[1]
image
[2]
image

@willdurand
Copy link
Member

@jvillalobos @wagnerand we should probably update the various policy pages because XXX for Firefox is still allowed according to https://extensionworkshop.com/documentation/publish/add-on-policies/ or https://www.mozilla.org/en-US/foundation/trademarks/policy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants