Merge pull request #1663 from kumar303/upload-size-fix

Temporarily stop tracking scaled upload stats

src/olympia/devhub/tasks.py

@@ -181,6 +181,13 @@ def handle_upload_validation_result(results, upload_pk, annotate=True):
     delta = now_ts - upload_start
     statsd.timing('devhub.validation_results_processed', delta)
 
+    if not storage.exists(upload.path):
+        # TODO: actually fix this so we can get stats. It seems that
+        # the file maybe gets moved but it needs more investigation.
+        log.warning('Scaled upload stats were not tracked. File is '
+                    'missing: {}'.format(upload.path))
+        return
+
     size = Decimal(storage.size(upload.path))
     megabyte = Decimal(1024 * 1024)
 

src/olympia/devhub/tests/test_tasks.py

@@ -348,6 +348,17 @@ def test_do_not_calculate_scaled_time_for_empty_files(self):
 
         assert 'devhub.validation_results_processed_per_mb' not in statsd_calls
 
+    def test_ignore_missing_upload_paths_for_now(self):
+        with mock.patch('olympia.devhub.tasks.storage.exists') as mock_exists:
+            mock_exists.return_value = False
+            with self.statsd_timing_mock() as statsd_calls:
+                self.handle_upload_validation_result()
+
+        assert 'devhub.validation_results_processed' in statsd_calls
+        assert 'devhub.validation_results_processed_per_mb' not in statsd_calls
+        assert ('devhub.validation_results_processed_under_1mb' not in
+                statsd_calls)
+
 
 class TestTrackValidatorStats(TestCase):