Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the button label @ /developers/addon/submit/agreement more readable #4772

Closed
krupa opened this issue Sep 13, 2017 · 7 comments · Fixed by mozilla/addons-server#6565
Closed

Comments

@krupa
Copy link

krupa commented Sep 13, 2017

Describe the problem and steps to reproduce it:

  1. Load https://addons-dev.allizom.org/en-US/developers/addon/submit/agreement
  2. Notice the button label

What happened?

Button label is grammatically correct but is too lengthy and not very readable.

What did you expect to happen?

Button label is readable. Suggest changing the copy to "Yes, I Accept" because there is copy above which clearly states that clicking the button means they have read the links.

screenshot

screenshot 2017-09-13 16 22 13

@diox
Copy link
Member

diox commented Sep 13, 2017

That's for @jvillalobos to decide

@jvillalobos
Copy link

I think the button is okay, but maybe less so in other languages. We could move the text to a line above the buttons:

I have read and accept this Agreement and the Rules and Policies.
[Accept] or [Cancel]

@apoorvaeternity
Copy link

@jvillalobos
Suggestion:
I think it would be better to remove the text line
"I have read and accept this Agreement and the Rules and Policies."
from the page.
Just [Accept] or [Cancel] would be enough.
The page clearly states that it is an agreement. Plus we are also using checkboxes for both Agreement and Review Policies and Rules.

@jvillalobos
Copy link

That kind of statement is fairly standard in such UI, and it might have some legal implications. I'd rather keep it.

@ilmanzo
Copy link

ilmanzo commented Sep 26, 2017

already fixed ? in current tree I have this

image

@diox
Copy link
Member

diox commented Sep 26, 2017

@ilmanzo you need to enable the post-review waffle switch. You can do so using ./manage.py waffle_switch post-review on from inside the addons-server container.

@ilmanzo
Copy link

ilmanzo commented Sep 26, 2017

whops... Sorry :)
This seems simple to me, the only issue is to introduce a translation for 'Accept' string (we already have 'Cancel')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants