Force pygit2 global search path to be set to HOME environment variable. #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit problematic since there isn't a real good default value since it depends on how the app is hosted, if `HOME` is set correctly and many other circumstances. Let's enforce it to be the users home to make sure we are accessing a directory that we have the permissions to. Fixes #10320
diox
reviewed
Jan 7, 2019
| @@ -38,6 +39,24 @@ def test_temporary_worktree(): | |||
| assert worktree.name not in output | |||
|
|
|||
|
|
|||
| def test_enforce_pygit_global_search_path_to_home(): | |||
| # https://github.com/mozilla/addons-server/issues/10320 | |||
| pygit2.settings.search_path[pygit2.GIT_CONFIG_LEVEL_GLOBAL] = '/root' | |||
There was a problem hiding this comment.
Shouldn't you revert this to the original value ? And also make sure that it is indeed reverted, regardless of whether the test succeeds or not ?
There was a problem hiding this comment.
indeed, I'll fix that.
diox
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit problematic since there isn't a real good default value since
it depends on how the app is hosted, if
HOMEis set correctly and manyother circumstances. Let's enforce it to be the users home to make sure
we are accessing a directory that we have the permissions to.
Fixes #10320